Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unlock-app): Improve event handling consistency across components #15551

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Feb 24, 2025

Description

This PR introduces consistent event handling logic across Event and Event Collection components/pages, ensuring uniform behavior.

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 February 24, 2025 13:11
@cla-bot cla-bot bot added the cla-signed label Feb 24, 2025
Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unlock-airdrops ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 1:32pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unlock-static-site ⬜️ Ignored (Inspect) Feb 24, 2025 1:32pm
unlock-storybook ⬜️ Ignored (Inspect) Feb 24, 2025 1:32pm

@julien51
Copy link
Member

Nice

@0xTxbi 0xTxbi merged commit 9762cd3 into master Feb 24, 2025
15 checks passed
@0xTxbi 0xTxbi deleted the streamlined-event-handling branch February 24, 2025 13:38
julien51 pushed a commit that referenced this pull request Feb 24, 2025
…#15551)

* improve event collection drawer

* clean up

* add event date formatter util

* consume util

* type corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants